Code Review

Summary: This PR replaces 8 hardcoded BulkProcessor/queue/client instances with a single shared LinkedBlockingDeque<List<byte[]>> drained by N RoutedBulkIndexer threads, and switches serialization from JSON to Jackson Smile binary format. This is a significant simplification — ~400 lines of copy-paste boilerplate removed.

The changes look correct. A few observations:

Shutdown sequence is sound

The RoutedBulkIndexer correctly handles the interrupt-based shutdown: after exiting the main loop it clears the interrupt flag via Thread.interrupted() and flushes any pendingDocs that were polled but not yet submitted. The caller in SourceDocumentCreation waits for the queue to drain, then interrupts and joins — this cooperates properly with the indexer's flush logic.

Minor observations (non-blocking)

1. Commented-out code in JSONProducer — lines like //jsonDoc = sequenceWriter.writeValueAsString(ssd); and the large block of debug logging comments (~10 lines) could be cleaned up since they reference the old JSON path that no longer exists.

2. System.exit(-1) on exhausted retries (RoutedBulkIndexer:264) — this is carried over from the old BulkProcessor listener pattern, so not a regression, but worth noting it will kill the entire JVM without cleanup of other threads.

3. maxRetries=100 with exponential backoff — at retry 10+ the sleep is capped at ~17 minutes per attempt (1 << 10 * 1000ms). Retries 11-100 all sleep 17 minutes each, so worst case is ~25 hours of retrying before giving up. This is likely intentional for a long-running indexing job, just calling it out.

No correctness issues, no security concerns, no breaking API changes. LGTM.

🤖 Generated with Claude Code